Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-pp: include privlib #789

Merged
merged 3 commits into from
Aug 23, 2023
Merged

make-pp: include privlib #789

merged 3 commits into from
Aug 23, 2023

Conversation

gugod
Copy link
Owner

@gugod gugod commented Aug 23, 2023

privlib contains all core libs and therefore should be part of the output.

privlib usually contains all "core modules".

Core modules are only included in PAR if they are detected
as a dependency by pp. In case of detection failures, the
only way to manually put a core module in a PAR would be
to add -M paramaters.

Here is one such failure case:

    # pp --bundle  -o ack =ack

    # ls | ./ack a
    Undefined subroutine &Term::ANSIColor::colored called at script/ack line 995, <STDIN> line 1.

    # unzip -l ack | grep Term
        13043  08-23-2023 09:37   lib/Term/Cap.pm

About Term::ANSIColor

    # corelist Term::ANSIColor

    Data for 2023-07-02
    Term::ANSIColor was first released with perl v5.6.0

    # perldoc -l Term::ANSIColor
    /home/gugod/perl5/perlbrew/perls/perl-5.38/lib/5.38.0/Term/ANSIColor.pm

The obvious way to overkill this problem is to always include the entire
privlib in the PAR.
@gugod gugod merged commit 6e2c694 into develop Aug 23, 2023
2 checks passed
@gugod gugod deleted the make-pp-include-privlib branch August 23, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant